-
Notifications
You must be signed in to change notification settings - Fork 29
Feat:lesson06 expression calculator Wayleon Vargas #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:lesson06 expression calculator Wayleon Vargas #312
Conversation
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎓 Automated Grading Report
Student: Wayleom Vargas
Date: 8/21/2025
Feedback
Wayleom Vargas has successfully configured the .env.test file with the correct group letter 'E', and implemented the calculate method in expression_calculator.ts to meet the functional requirements. The calculation logic is correctly implemented as Math.pow((a + b) / c, d) * e, which aligns with the assignment's requirements. However, the GitHub checks have failed, indicating potential issues with code style, TypeScript errors, or other technical aspects that need to be addressed. This affects the technical score, as all checks must pass for full marks. For the stretch assignment, the student has made an initial attempt by setting up the function signature and some basic validation checks. However, the implementation is incomplete and does not address the core logic required to validate the abbreviation against the word. To improve, the student should focus on completing the logic for the stretch assignment and ensuring all GitHub checks pass by reviewing and correcting any technical issues in the code.
This is an automated preliminary review. Please review and adjust before finalizing.
| // Implement your code here to return the correct value. | ||
| return 0; | ||
| // Function to implement: Math.pow((a + b) / c, d) * e | ||
| return Math.pow((a + b) / c, d) * e; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were to implement the math methods and use them instead of just doing the arithmetic directly. That's part of the reason why the tests don't pass.
| @@ -0,0 +1,14 @@ | |||
| function isValidAlphaAbbreviation(word: string, abbr: string): boolean { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got some work to do before this is close to working. Also, try to come up with a better name for this file.
No description provided.